Skip to content

Conversation

@shyim
Copy link
Member

@shyim shyim commented Jan 6, 2026

Reduce the wall of docker image choices,

@shyim shyim marked this pull request as draft January 6, 2026 14:24
@shyim shyim force-pushed the fix/reduce-options branch from 60291c5 to c493dea Compare January 6, 2026 14:28
@shyim shyim marked this pull request as ready for review January 6, 2026 14:29
@shyim shyim force-pushed the fix/reduce-options branch from c493dea to b4466d4 Compare January 6, 2026 14:29
@shyim shyim requested a review from Isengo1989 January 7, 2026 08:00
@Isengo1989
Copy link
Contributor

Isengo1989 commented Jan 7, 2026

@shyim , what do you think about adding a link to Docker Hub somewhere? (https://hub.docker.com/r/shopware/docker-base/tags)

I suppose removing nginx does give fewer options, which is simpler, but why is Caddy preferred over nginx?

image

@shyim
Copy link
Member Author

shyim commented Jan 7, 2026

We could link https://github.com/shopware/docker/pkgs/container/docker-base, would like to get rid of docker hub in future 🙈

In future we want that people only use frankenphp, but idk how we get there. Maybe we really only list and add a blue/yellow whatever banner

@Isengo1989
Copy link
Contributor

We could link https://github.com/shopware/docker/pkgs/container/docker-base, would like to get rid of docker hub in future 🙈

In future we want that people only use frankenphp, but idk how we get there. Maybe we really only list and add a blue/yellow whatever banner

Ok, I would say we can go full on then right away, otherwise it's a half way change.

I will

  1. Remove caddy from the list
  2. Add an info with a link to GHCR if other images like nginx and caddy are wanted / needed.

if thats fine by you.

@Isengo1989 Isengo1989 added the Improvement PR created to append/modify info in the existing article label Jan 8, 2026
@shyim
Copy link
Member Author

shyim commented Jan 9, 2026

yes

@Isengo1989
Copy link
Contributor

@shyim I removed caddy as discussed and one of the best practices still hinting to nginx over caddy

dee66ec

@Isengo1989 Isengo1989 self-requested a review January 20, 2026 14:33
Copy link
Contributor

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR @shyim 👍

@shyim
Copy link
Member Author

shyim commented Jan 20, 2026

looks good thanks :D

@Isengo1989 Isengo1989 merged commit 50a7642 into main Jan 21, 2026
8 checks passed
@Isengo1989 Isengo1989 deleted the fix/reduce-options branch January 21, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement PR created to append/modify info in the existing article

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants