-
Notifications
You must be signed in to change notification settings - Fork 302
fix(docker): reduce image variant options #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
60291c5 to
c493dea
Compare
c493dea to
b4466d4
Compare
|
@shyim , what do you think about adding a link to Docker Hub somewhere? (https://hub.docker.com/r/shopware/docker-base/tags) I suppose removing nginx does give fewer options, which is simpler, but why is Caddy preferred over nginx?
|
|
We could link https://github.com/shopware/docker/pkgs/container/docker-base, would like to get rid of docker hub in future 🙈 In future we want that people only use frankenphp, but idk how we get there. Maybe we really only list and add a blue/yellow whatever banner |
Ok, I would say we can go full on then right away, otherwise it's a half way change. I will
if thats fine by you. |
|
yes |
dee66ec to
778c880
Compare
Isengo1989
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR @shyim 👍
|
looks good thanks :D |

Reduce the wall of docker image choices,